This repository has been archived by the owner on May 16, 2018. It is now read-only.
Zend_Validate_EmailAddress: IDN domains are converted to punnycode if possible #470
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(The question is wheter such "progressive enhancement" dependant on PHP version should be merged to ZF1) |
We have two options:
|
|
ping @weierophinney |
mhujer
force-pushed
the
62-validate-idn-email
branch
from
419bfb0 to
aecbe58
Compare
mhujer
force-pushed
the
62-validate-idn-email
branch
from
aecbe58 to
c7a2727
Compare
|
ping @weierophinney |
|
I'm all for progressive/forwards-compat fixes. If this cannot be fixed in 5.2, I think we can just call that out in the release announcement. People on 5.2 really need to upgrade at this point anyways, and this gives another reason to do so. |
|
@weierophinney |
froschdesign
added a commit
that referenced
this pull request
Jan 5, 2015
Zend_Validate_EmailAddress: IDN domains are converted to punnycode if possible
|
@froschdesign why did you remove the 1.12.10 milestone? |
|
@akrabat |
|
aha! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62
The problem is that IDN domain cannot be converted to
xn--in PHP 5.2 (there are some PHP libraries, that implement it, but we can't include them in ZF). So this is rather a "progressive enhacement" for PHP 5.3+ (with intl enabled)cc @froschdesign